Merged
Conversation
Member
|
Is it maybe that the Docker registry digest SHAs don't match the Git commit SHAs...? 🤷🏻♂️ I am admittedly not well-versed in Docker. 😕 |
JamesMGreene
approved these changes
Oct 15, 2020
Member
JamesMGreene
left a comment
JamesMGreene
left a comment
There was a problem hiding this comment.
Approving this as a revert to get things functioning again. 👍🏻
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨ |
This was referenced May 18, 2021
jnidzwetzki
pushed a commit
to jnidzwetzki/docs
that referenced
this pull request
Oct 6, 2022
* remove comment * update * add full url * add slashes * add full url * finish broken internal doc links
This was referenced Dec 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When moving to shas for more security, it looks like we broke the Docker action.
This should get it working again. Ideally we move to a Sha somehow in the future but I'm unsure how to do that considering the unique format of this Action being served from Docker rather than GitHub.
Example of the Action breaking: https://github.com/github/docs/actions/runs/309155706/workflow
Check off the following: